Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typos #264

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Fixing typos #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions text/0000-non-context-shifting-partials.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Specifically:
template.

Users who are familiar with how component invocations work today should find the
second form quite familar and easy to understand (which further highlights the
second form quite familiar and easy to understand (which further highlights the
oddities of the first/current form).

In addition, we will pair this change with a deprecation. When a partial template
Expand Down Expand Up @@ -189,7 +189,7 @@ It is also probably the case that for someone who is completely new to Ember, th
have no reason to expect partials to work the way they do today – after all, it is quite
normal to have to explicitly pass in any data you need in every other context (component
invocation, function calls, etc). So, arguably, this is actually one *fewer* thing to
teach and might actually align better with everyone's metal model of how programming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

teach and might actually align better with everyone's mental model of how programming
works.

For existing users who are already familiar with how components work, this should also
Expand Down