From 431673d23bc20c276588d78816fc70da09954176 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ivan=20Lu=C4=8Din?= Date: Fri, 10 Nov 2017 15:22:54 +0100 Subject: [PATCH] Add failing test for computed.filter @each with {} regression --- .../computed/reduce_computed_macros_test.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/packages/ember-runtime/tests/computed/reduce_computed_macros_test.js b/packages/ember-runtime/tests/computed/reduce_computed_macros_test.js index 96c1499199b..2fee357c838 100644 --- a/packages/ember-runtime/tests/computed/reduce_computed_macros_test.js +++ b/packages/ember-runtime/tests/computed/reduce_computed_macros_test.js @@ -344,6 +344,24 @@ QUnit.test('it updates as the array is replaced', function() { deepEqual(obj.get('filtered'), [20, 22, 24], 'computed array is updated when array is changed'); }); +QUnit.test('it updates properly on @each with {} dependencies', function() { + let item = EmberObject.create({prop: true}); + + obj = EmberObject.extend({ + filtered: filter('items.@each.{prop}', function(item, index) { + return item.get('prop') === true; + }) + }).create({ + items: [item] + }); + + deepEqual(obj.get('filtered'), [item]); + + item.set('prop', false); + + deepEqual(obj.get('filtered'), []); +}); + QUnit.module('filterBy', { setup() { obj = EmberObject.extend({