-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port applyAttributeBindings
to attr nodes
#9921
Comments
I'll give this and #9922 a shot. From what I've seen it looks like doing them one at a time might be messier than together, since attribute nodes need to be created after the element has been generated whereas under the old way the bindings are set up before the |
@oneeman I wonder if this might not be appropriate any more, apologies. I'm working on splitting attr nodes into an attribute morph object in HTMLBars, and an attrview object that is managed via the renderer. I believe this is required in order to port attribute bindings to a shared system with |
No worries, I've just been familiarizing myself with the view layer, so it's all good. |
@mixonic - I believe that this is something you are working on currently, c/d? |
I have this underway with just a few more tests failing. It is a large number of changes. |
applyAttributeBindings
is slow. It should be ported to use streams and attr nodes.The text was updated successfully, but these errors were encountered: