Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port applyAttributeBindings to attr nodes #9921

Closed
mixonic opened this issue Dec 15, 2014 · 5 comments · Fixed by #10186
Closed

Port applyAttributeBindings to attr nodes #9921

mixonic opened this issue Dec 15, 2014 · 5 comments · Fixed by #10186

Comments

@mixonic
Copy link
Member

mixonic commented Dec 15, 2014

applyAttributeBindings is slow. It should be ported to use streams and attr nodes.

@oneeman
Copy link
Contributor

oneeman commented Dec 26, 2014

I'll give this and #9922 a shot. From what I've seen it looks like doing them one at a time might be messier than together, since attribute nodes need to be created after the element has been generated whereas under the old way the bindings are set up before the buffer.generateElement() call (correct me if I'm confused here).

@mixonic
Copy link
Member Author

mixonic commented Dec 26, 2014

@oneeman I wonder if this might not be appropriate any more, apologies. I'm working on splitting attr nodes into an attribute morph object in HTMLBars, and an attrview object that is managed via the renderer. I believe this is required in order to port attribute bindings to a shared system with bind-attr and htmlbars-syntax attrs.

@oneeman
Copy link
Contributor

oneeman commented Dec 26, 2014

No worries, I've just been familiarizing myself with the view layer, so it's all good.

@rwjblue
Copy link
Member

rwjblue commented Jan 4, 2015

@mixonic - I believe that this is something you are working on currently, c/d?

@mixonic
Copy link
Member Author

mixonic commented Jan 5, 2015

I have this underway with just a few more tests failing. It is a large number of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants