[3.13.0-beta.1] Nested key dependency warning now throws an error

[patocallaghan]

I'm not sure if this is a regression but I wanted to raise it anyway as others upgrading may encounter the issue. Feel free to close if you think it isn't a problem.

In ember-source 3.12 and earlier, having a computed property which has invalid nested key dependencies resulted in a warning, but in ember-source 3.13.0-beta.1 it results in an error.

Take the following example where using @each with items.id is invalid

badNestedDependency: computed('items.@each.subitems.id', function() {
  // ... snip ...
}),

In 3.12 and lower

In 3.13 beta

I encountered this as currently our app has several instances of these invalid keys (which we definitely will be fixing!) but when trying out the beta our app broke and didn't render (in development).

My understanding was that to start throwing error assertions it needed to go through a deprecation cycle but it doesn't appear the nested key warning has. It was never explicitly named as a deprecation warning when introduced.

The error assertion appeared with the new @tracked work.

Reproduction

Code Sandbox Ember 3.12
Code Sandbox Ember 3.13 beta
Look in the console for the warning vs error, and the nested key code is in app/components/nested-key-component.js

[rwjblue]

@pzuraq - Do you recall why we moved the warning to an assertion? Can we migrate back?

[patocallaghan]

@rwjblue @pzuraq any update here? Is this an expected change?

[pzuraq]

Ah, I'd just thought that this was an invalid use case in general. We can add it back 👍

[rwjblue]

Chatted a bit with @pzuraq offline, I think we want to make this a deprecation (instead of an assert) which mitigates the immediate issue in 3.13. Since this was never documented (or even functional) the deprecation can be an intimate API one and the moved back to an assertion in 3.17 or later.

[patocallaghan]

Closing as this has now become a proper deprecation warning instead. Thanks!

[rwjblue]

Thanks for double checking!