-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internet Explorer IE9: _emberEnvironment.environment.global returns undefined
#14006
Comments
@darylalexjohnson can you share the repository you used to reproduce the issue, here? It will be helpful for confirming and debugging the issue. |
I can confirm this happens with a vanilla 2.7.0
|
I can also confirm this. Try to see the live demo on IE9 of a simple ember app running 2.7: https://github.com/zoltan-nz/library-app. Like @darylalexjohnson was pointing out, the global param is |
Hmm. Our test suite runs against IE9 and seems to be passing. Does someone have a minute to try and submit a failing test case? I wonder if this is coming from Ember itself or something that is included by default in a new ember-cli app. I'll try to get my IE9 VM working again to test, but it may take a few days (doing a bit of vacation...) |
@rwjblue If you have IE11 running, you can also simulate IE9, which is giving you more useful console output also. Will see if I can create a failing test if I have some time tomorrow (also a bit of vacation ;) ) |
I can confirm that this happens when visiting https://ember-twiddle.com/ , which is currently on ember 2.7.0. Tested with IE9 on windows 7 through Browserstack. |
This is due to a rename from environment.global to environment.window in this commit However this still tries to use environment.global, which is no longer defined |
Can someone take a look at this, seems crucial to me. |
Thx @rwjblue |
After upgrading one of our apps to 2.7, it failed to load in IE9. I reproduced the issue by installing a new sandbox app with v2.7. The error is thrown in
supportsHashChange
withglobal
beingundefined
.Reverting to 2.6 resolves the issue.
The text was updated successfully, but these errors were encountered: