Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this._super() broken after this.reopen() #12786

Closed
Emrvb opened this issue Jan 8, 2016 · 4 comments
Closed

this._super() broken after this.reopen() #12786

Emrvb opened this issue Jan 8, 2016 · 4 comments
Assignees

Comments

@Emrvb
Copy link

Emrvb commented Jan 8, 2016

After a reopen() , super methods can no longer be called.

Works until (and including) 2.0.2
Broken in 2.1.1

Example:
https://ember-twiddle.com/17156052c6d43e24168b

PS.

Considering this is an edge case. Documenting this behavior or triggering a warning/assertion when calling reopen on a constructed class is a fix to me.

@rwjblue
Copy link
Member

rwjblue commented Jan 8, 2016

We had a similar issue that was fixed in emberjs/ember-inspector#481. Calling reopen on an instantiated class seems "weird" at best. I'm not sure that there is much to be done to actually fix the underlying issue here...

@stefanpenner
Copy link
Member

unsure if it is related but: this._super(); requires this._super.apply(this, arguments)

@stefanpenner
Copy link
Member

Documenting this behavior or triggering a warning/assertion when calling reopen on a constructed class is a fix to me.

We want to kill this feature, as it can't reasonable be made to work correctly in all scenarios, and still be performant.

@Emrvb
Copy link
Author

Emrvb commented Jan 11, 2016

Well, removal and hitting "undefined is not a function" is also a fix that would have saved me an hour debugging :P.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants