Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[canary] Link component no longer binds href. #12302

Closed
nathanhammond opened this issue Sep 7, 2015 · 7 comments · Fixed by #12318
Closed

[canary] Link component no longer binds href. #12302

nathanhammond opened this issue Sep 7, 2015 · 7 comments · Fixed by #12318

Comments

@nathanhammond
Copy link
Member

Working on a bisect, but the link-to component doesn't appear to trigger computed properties fired during the willRender hook. As a consequence there is no href property bound on the component.

Broken as of the commit prior to my link-to cleanup work landing, known to work as of the base of my fork I started for cleanup.

@nathanhammond
Copy link
Member Author

This is the commit that breaks link-to.

I'm assuming that all of the tests still pass (including the ones that inspect the href attribute), so this appears to be a very insidious bug.

/cc @wycats

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2015

Can you make a reproduction JSBin or submit a failing test PR? The test suite does indeed pass, which seems odd if link-to href is completely busted...

@nathanhammond
Copy link
Member Author

Repro. Inspect the anchor and note that it doesn't have an href.

It's literally as simple as it possibly could be. If you click on the link it still works (_invoke gets fired) so I'm imagining that's why tests still continue to pass. Also, maybe forced lazy evaluation of the computed property by accessing it is having the attr show up "just in time" in the tests?

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2015 via email

@nathanhammond
Copy link
Member Author

Works on 2.1.0-beta.3, works on current beta channel.

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2015 via email

@rwjblue
Copy link
Member

rwjblue commented Sep 10, 2015

Submitted #12318 with a writeup and a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants