-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[canary] Link component no longer binds href. #12302
Comments
This is the commit that breaks link-to. I'm assuming that all of the tests still pass (including the ones that inspect the /cc @wycats |
Can you make a reproduction JSBin or submit a failing test PR? The test suite does indeed pass, which seems odd if link-to href is completely busted... |
Repro. Inspect the anchor and note that it doesn't have an It's literally as simple as it possibly could be. If you click on the link it still works ( |
I'm mobile ATM, can you test on 2.1.0-beta.3 also?
|
Works on 2.1.0-beta.3, works on current beta channel. |
Thank you!
|
Submitted #12318 with a writeup and a fix. |
Working on a bisect, but the
link-to
component doesn't appear to trigger computed properties fired during thewillRender
hook. As a consequence there is nohref
property bound on the component.Broken as of the commit prior to my link-to cleanup work landing, known to work as of the base of my fork I started for cleanup.
The text was updated successfully, but these errors were encountered: