-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember.run.later is halting under certain circumstances #12193
Comments
At a glance, this sounds like a duplicate of #10479 which in turn is an upstream bug at BackburnerJS/backburner.js#135. |
@dtetto - Yes, I just came to the same conclusion. Thank you for linking! |
Consolidated some of the related PR's together: BackburnerJS/backburner.js#146 |
Will be fixed by #12331, but @stefanpenner will have to review to see if this is eligible for backporting. |
I'll take care of the backport |
Shameless Bump. This was the root cause of an issue a customer reported for us. We're still on 1.13.x and would really love to get this fixed. |
I haven't had time, @workmanw care to submit a PR backporting backburner? |
@stefanpenner If you give me a little bit of direction, I'd be more than happy to. It seems to be fixed in backburner and backburner seems to be pulled in via bower (https://github.com/emberjs/ember.js/blob/release-1-13/bower.json#L9). So is the PR just as simple as updating the 'bower.json' or is there more to it? |
yup |
Fix back ported in #12449 |
Here is a twiddle demoing it for 1.13.6. I've also tested this for 2.0.0:
http://ember-twiddle.com/d7e78ce7132882773232
The gist can be found here:
http://ember-twiddle.com/d7e78ce7132882773232
The demonstration has a timer value being updated via
Ember.run.next
continuously. When it is running calls toEmber.run.later
will halt the update of the value until the full duration ofEmber.run.later
has expired.If
Ember.run.later
is replaced with a simplesetTimeout
there is no halting. I did not experience this problem on 1.12.x.If I can assist in any way please let me know. ❤️
The text was updated successfully, but these errors were encountered: