Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer] willDestroyElement is sometimes called again when the outlet view destroys the toplevel view #11077

Closed
krisselden opened this issue May 8, 2015 · 5 comments · Fixed by #11425
Assignees
Labels
Milestone

Comments

@krisselden
Copy link
Contributor

I noticed this failing a unit test during App.reset() so this reproduction is based on that.
http://emberjs.jsbin.com/zuzamilapa/2/edit

There are other cases of it during a route transition that I haven't made a reduce reproduction yet. Just wanted to track this.

@krisselden krisselden added the Bug label May 8, 2015
@krisselden krisselden self-assigned this May 8, 2015
@krisselden krisselden added this to the 1.13.0-beta.1 milestone May 8, 2015
@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

@krisselden - Any progress/updates on tracking this down?

@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

Added test for ensuring childViews is maintained when render nodes are removed: https://github.com/emberjs/ember.js/compare/child-views-maintained.

@krisselden
Copy link
Contributor Author

@krisselden
Copy link
Contributor Author

the above illustrates the issue with childViews and willDestroyElement being called twice.

@runspired
Copy link
Contributor

Any progress?

Encountered this this evening (via ember-wormhole), it quickly spirals into deathly recursion :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants