Ember.Controller._calculateCacheKey() failure when routes nested

[amurchick]

JSBin example for catch this - http://jsbin.com/zoyoqi#/potatoes/one?filter=filterValue&nextFilter=nextFilterValue

_calculateCacheKey() failure causes incorrect store/restore of nextFilter query parameter in Ember.Controller - if you see on links href's in JSBin example - you will see:

    <a id="ember296" class="ember-view" href="#/badgers/one?nextFilter=nextFilterValue">Badgers</a>
    <a id="ember297" class="ember-view" href="#/badgers/two?nextFilter=nextFilterValue">Badgers</a>
    <a id="ember298" class="ember-view" href="#/bears/one?nextFilter=nextFilterValue">Bears</a>
    <a id="ember299" class="ember-view active" href="#/potatoes/one?filter=filterValue&nextFilter=nextFilterValue">Potatoes</a>

In other words, nextFilter value for route #/potatoes/one sets same for all routes.

However value of filter correctly works as described by http://guides.emberjs.com/v1.11.0/routing/query-params/ in section STICKY QUERY PARAM VALUES.

What leads to failure?
Set breakpoint in http://builds.emberjs.com/beta/ember.debug.js in line 19744:

var value = property_get.get(values, part);

with condition part === "team.tear.tear_menu_id" and after debugger stops - execute line on which debugger stops.

Result: value will be set to undefined, because we are try get team.tear.tear_menu_id, but values contains:

{
    "team.tear": {
        tear_menu_id: "one"
    }
}

Simplest example:

Ember.get({'a.b': {c: 10}}, 'a.b.c')

returns undefined.

[amurchick]

@rwjblue Do you plan fix this issue?

[trek]

I've been trying to understand what this report is for about 30 minutes now, but am having trouble understanding what you're saying. Can you provide more structure around descriptions of what you're seeing, what you expect to see, and steps to reproduce that limit the code only the portions required to illustrate the issue?

I think you're describing the intended behavior

[rlivsey]

If I'm following correctly, I think this is a duplicate / along the same lines as #3638 and #9630

[trek]

@rlivsey that would be an underlying cause of the problem (?), but is really just implementation detail @amurchick uncovered. I'm still trying to figure out what the public API bug is based on the report.

[amurchick]

@trek I am very accurate describe problem, ok, I will try again...

When the bug occurs?

When you use query parameters in nested routes.

How to produce?

• Navigate to http://output.jsbin.com/zoyoqi#/badgers/one?nextFilter=nextFilterValue
• See elements in developer console and you will see, for all routes nextFilter has value nextFilterValue:
  
• Try to change nextFilterValue for example on newValue - see elements again:
  

Whats wrong?

For every /:team_menu_id/:tear_menu_id values of query parameter nextFilter are equals.

Why this happens?

Please, see first comment.

What I am expect?

I am expect value of query parameter nextFilterValue will be changed only for /badgers/one, not for all other routes.
For every /:team_menu_id/:tear_menu_id query parameter nextFilter must have own value as described at http://guides.emberjs.com/v1.12.0/routing/query-params/#toc_specifying-query-parameters

There is any case exists, when this worked as described?

Yes, when we do not use nested routes:

• Navigate to http://output.jsbin.com/zoyoqi#/badgers?filter=123
• We will see - all correct, since query parameter filter defined on /:team_menu_id level:
  
• Click on link Bears and URL will be changed to http://output.jsbin.com/zoyoqi#/bears/one
• Simply add ?filter=456 to URL (do not reload page, only write this at end of URL) and press enter and you will see:
  

E.g., for every /:team_menu_id route - query parameter filter has own value.

[jmurphyau]

Basically the bug is: query params are not sticky on nested routes.

The cacheKey is not being calculated correctly since nested routes have a dot in their name and get doesn't work with keys that have a dot..

@trek I've got a PR that has a failing test and fix but only for query params on controllers not for query params on routes (which is a feature that isn't enabled yet though).. Spent some time trying to figure it out but couldn't manage to and can't spend any more time on it..

I'll push it within the next hr or so

[jmurphyau]

Didn't get a chance to push the PR but I may have got it for route defined query params.. Will push it tomorrow