diff --git a/packages/@ember/-internals/glimmer/lib/components/input.ts b/packages/@ember/-internals/glimmer/lib/components/input.ts index 9d7892fbd31..235f4ba84cc 100644 --- a/packages/@ember/-internals/glimmer/lib/components/input.ts +++ b/packages/@ember/-internals/glimmer/lib/components/input.ts @@ -927,20 +927,18 @@ if (EMBER_MODERNIZED_BUILT_IN_COMPONENTS) { const actionName = this.arg(type); if (typeof actionName === 'string') { - // TODO: eagerly issue a deprecation for this as well (need to fix tests) - // - // deprecate( - // `Passing actions to components as strings (like \`<${this.constructor} @${type}="${actionName}" />\`) is deprecated. ` + - // `Please use closure actions instead (\`<${this.constructor} @${type}={{action "${actionName}"}} />\`).`, - // false, - // { - // id: 'ember-component.send-action', - // for: 'ember-source', - // since: {}, - // until: '4.0.0', - // url: 'https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action', - // } - // ); + deprecate( + `Passing actions to components as strings (like \`<${this.constructor} @${type}="${actionName}" />\`) is deprecated. ` + + `Please use closure actions instead (\`<${this.constructor} @${type}={{action "${actionName}"}} />\`).`, + false, + { + id: 'ember-component.send-action', + for: 'ember-source', + since: {}, + until: '4.0.0', + url: 'https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action', + } + ); const { caller } = this; diff --git a/packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js b/packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js index 5daed326443..b84f77dfdc9 100644 --- a/packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js +++ b/packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js @@ -609,11 +609,11 @@ moduleFor( }, }, }); - }, 'Passing actions to components as strings (like ``) is deprecated. Please use closure actions instead (``). (\'-top-level\' @ L1:C0) '); + }, /Passing actions to components as strings \(like `({{input key-press="foo"}}|)`\) is deprecated\./); expectDeprecation(() => { this.triggerEvent('keypress', { key: 'A' }); - }, 'Passing actions to components as strings (like ``) is deprecated. Please use closure actions instead (``).'); + }, /Passing actions to components as strings \(like `({{input key-press="foo"}}|)`\) is deprecated\./); } ['@test sends an action with `` is pressed'](assert) { @@ -765,7 +765,7 @@ moduleFor( }, }, }); - }, 'Passing actions to components as strings (like ``) is deprecated. Please use closure actions instead (``). (\'-top-level\' @ L1:C0) '); + }, /Passing actions to components as strings \(like `({{input key-down="foo"}}|)`\) is deprecated\./); expectDeprecation(() => { this.triggerEvent('keydown', { key: 'A' }); @@ -811,7 +811,7 @@ moduleFor( }, }, }); - }, 'Passing actions to components as strings (like ``) is deprecated. Please use closure actions instead (``). (\'-top-level\' @ L1:C0) '); + }, /Passing actions to components as strings \(like `({{input key-up="foo"}}|)`\) is deprecated\./); expectDeprecation(() => { this.triggerEvent('keyup', { key: 'A' }); diff --git a/packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js b/packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js index 61a0acd4933..12a08eb8022 100644 --- a/packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js +++ b/packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js @@ -439,11 +439,11 @@ moduleFor( }, }, }); - }, 'Passing actions to components as strings (like `{{input key-press="foo"}}`) is deprecated. Please use closure actions instead (`{{input key-press=(action "foo")}}`). (\'-top-level\' @ L1:C0) '); + }, /Passing actions to components as strings \(like `({{input key-press="foo"}}|)`\) is deprecated\./); expectDeprecation(() => { this.triggerEvent('keypress', { key: 'A' }); - }, 'Passing actions to components as strings (like ``) is deprecated. Please use closure actions instead (``).'); + }, /Passing actions to components as strings \(like `({{input key-press="foo"}}|)`\) is deprecated\./); } ['@test sends an action with `{{input key-press=(action "foo")}}` is pressed'](assert) { @@ -595,7 +595,7 @@ moduleFor( }, }, }); - }, 'Passing actions to components as strings (like `{{input key-down="foo"}}`) is deprecated. Please use closure actions instead (`{{input key-down=(action "foo")}}`). (\'-top-level\' @ L1:C0) '); + }, /Passing actions to components as strings \(like `({{input key-down="foo"}}|)`\) is deprecated\./); expectDeprecation(() => { this.triggerEvent('keydown', { key: 'A' }); @@ -641,7 +641,7 @@ moduleFor( }, }, }); - }, 'Passing actions to components as strings (like `{{input key-up="foo"}}`) is deprecated. Please use closure actions instead (`{{input key-up=(action "foo")}}`). (\'-top-level\' @ L1:C0) '); + }, /Passing actions to components as strings \(like `({{input key-up="foo"}}|)`\) is deprecated\./); expectDeprecation(() => { this.triggerEvent('keyup', { key: 'A' });