From d1bc83db3296c4f1d4b3555ecacd79b478f612f3 Mon Sep 17 00:00:00 2001 From: Chris Parry Date: Wed, 31 Jan 2018 13:27:52 +0000 Subject: [PATCH] [BUGFIX beta] prevent test error by converting illegal characters in branch name null fix --- broccoli/version.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/broccoli/version.js b/broccoli/version.js index bd86a9df225..94af0f98dd6 100644 --- a/broccoli/version.js +++ b/broccoli/version.js @@ -25,9 +25,11 @@ module.exports.VERSION = (() => { // * current "build type" or branch name (in CI this is generally not // present, but it is very useful for local / testing builds) // * the sha for the commit - let packageVersion = pkg.version; + let packageVersion = pkg.version; let sha = info.sha || ''; let suffix = process.env.BUILD_TYPE || info.branch; + // * remove illegal non-alphanumeric characters from branch name. + suffix = suffix && suffix.replace(/[^a-zA-Z\d\s-]/, '-'); let metadata = sha.slice(0, 8); return `${packageVersion}${suffix ? '-' + suffix : ''}+${metadata}`;