-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean checkout is failing to build: "Unknown option: direct.console" #577
Comments
Ok, so this is both my fault and annoying. Basically, broccoli-babel-transpiler's options are intermixed with the options passed into the Babel instance that the broccoli plugin wraps. This means that anytime we add a new argument for the plugin the plugin must also delete the argument before passing the options through to Babel. |
We added a I suspect (hard to check while on mobile) that we have pinned broccoli-babel-transpiler to a version that doesn't account for removing 'console'. Can you check? If that is the issue, we should be able to fix by bumping to the latest 5.x release of broccoli-babel-transpiler. |
I'm getting the same error message as OP. broccoli-babel-transpiler is currently pinned to 5.1.0. that version does seem to handle |
Updating broccoli-babel-transpiler locally to 5.5.0 fixed it for me |
Ya, 5.1.0 link is here: https://github.com/babel/broccoli-babel-transpiler/blob/v5.1.0/index.js#L21-L30, and it doesn't handle @elbeezy - Mind sending a PR? |
oops, yeah i was looking at master >.< PR incoming |
Thanks all! |
Following the instructions in the Readme, I checked out the repo and ran:
And got this output:
The text was updated successfully, but these errors were encountered: