Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering tests unusable in ember-inspectors test suite #1201

Closed
3 tasks done
rwjblue opened this issue May 12, 2020 · 1 comment · Fixed by #1204
Closed
3 tasks done

Rendering tests unusable in ember-inspectors test suite #1201

rwjblue opened this issue May 12, 2020 · 1 comment · Fixed by #1204
Labels

Comments

@rwjblue
Copy link
Member

rwjblue commented May 12, 2020

Currently, adding any tests that use the setupTest/setupRenderingTest/setupApplicationTest testing infrastructure causes those tests to "randomly" fail (due to timeout errors).

After digging into it a bit, the issue seems to be caused by using setApplication in tests/helpers/setup-destroy-ei-app.js. Calling setApplication there (and then running app.destroy) causes all subsequent @ember/test-helpers based tests to timeout (the application instance that you pass to setApplication is supposed to never be destroyed).

TODO:

@rwjblue rwjblue added the bug label May 12, 2020
@rwjblue
Copy link
Member Author

rwjblue commented May 12, 2020

Just creating an issue to track progress...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant