[FEAT request-state-service] implements RFC 466 #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-north
reviewed
Jun 28, 2019
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
|
|
||
| class Person extends Model { | ||
| // TODO fix the typing for naked attrs | ||
| @attr('string', {}) |
There was a problem hiding this comment.
ping @mike-north about fixing this, if it's not already fixed. This should be a 5 minute job
There was a problem hiding this comment.
you can also just do @attr() name;
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
| type: 'mutation', | ||
| state: 'fulfilled', | ||
| request: { data: [savingRequestOp] }, | ||
| response: { data: undefined } |
There was a problem hiding this comment.
double check. might be
Suggested change
| response: { data: undefined } | |
| response: { } |
igorT
force-pushed
the
igor/request-state-service
branch
2 times, most recently
from
77725db
to
9e6cca2
Compare
runspired
approved these changes
Jul 24, 2019
|
|
||
| class Person extends Model { | ||
| // TODO fix the typing for naked attrs | ||
| @attr('string', {}) |
There was a problem hiding this comment.
you can also just do @attr() name;
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/integration/request-state-service-test.ts
Outdated
Show resolved
Hide resolved
runspired
changed the title
igorT
force-pushed
the
igor/request-state-service
branch
7 times, most recently
from
7b3472c
to
b0628c4
Compare
igorT
force-pushed
the
igor/request-state-service
branch
from
b0628c4
to
143e1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC text