Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup transpilation issues with @ember/ordered-set. #5557

Merged
merged 4 commits into from
Aug 8, 2018
Merged

Fixup transpilation issues with @ember/ordered-set. #5557

merged 4 commits into from
Aug 8, 2018

Commits on Aug 7, 2018

  1. Ensure tests run minimally transpiled.

    @rwjblue
    rwjblue committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    2353398 View commit details
    Browse the repository at this point in the history

  2. Add specific test run for full transpilation.

    @rwjblue
    rwjblue committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    c8acd36 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX beta] Prevent transpilation issues with @ember/ordered-set.

    @rwjblue
    rwjblue committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    1ec36d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2018

  1. Fix ES compatibility issues. 

    These cases were all previously working due to transpilation from `let`
to `var`. You *cannot* reference a block scoped variable (`let` /
`const`) during the variables own initializer.
    @rwjblue
    rwjblue committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    81decd0 View commit details
    Browse the repository at this point in the history