Fixup transpilation issues with @ember/ordered-set. #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cases were all previously working due to transpilation from `let` to `var`. You *cannot* reference a block scoped variable (`let` / `const`) during the variables own initializer.
|
Just pushed another commit here that shows how important these test harness changes are. We essentially had some code that was only working due to transpilation... |
|
Thanks @rwjblue ! I've been removing those sorts of |
runspired
approved these changes
Aug 8, 2018
This was referenced Aug 21, 2018
NullVoxPopuli
pushed a commit
to NullVoxPopuli/data
that referenced
this pull request
Sep 8, 2018
* Ensure tests run minimally transpiled. * Add specific test run for full transpilation. * [BUGFIX beta] Prevent transpilation issues with @ember/ordered-set. * Fix ES compatibility issues. These cases were all previously working due to transpilation from `let` to `var`. You *cannot* reference a block scoped variable (`let` / `const`) during the variables own initializer.
This was referenced Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit here, demonstrates the failure reported in #5556 by running the test suite in "Chrome only" mode.
Follow up commits clean things up, and ensure we test both transpiled maximally (down to IE11) and minimally.