[BUGFIX] inverseFor should respect inverse: null #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This supplants #5257 |
|
👍 on the code |
|
Though I'm not sure, I think this fix a bug I still encounter in 2.18. Would it be possible to backport this in 2.18 ? For now I tried to update to 3.0.0 beta, and this release seems to finally fix all the problem I encountered after 2.12.2. Really great job, I love you guys. |
|
@runspired I was also wondering if this would be available to backport to 2.18? That would be great to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5230 I discovered that our current resolution strategy for
inverseForwould improperly allow relationships that specifyinverse: nullto still be matched. This addresses that, adds a test, and fixes two tests that depended upon this bug.