Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move initialize-store-service.js out of the instance-initializers dir… #5238

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

bmac
Copy link
Member

@bmac bmac commented Oct 22, 2017

…ectory.

That directory seems to be suggesting to ember-load-initializers that
it is a full initializer object and causing an exception to be thrown
in the globals build.

Fixes #5118

@rwjblue would you mind reviewing this and letting me know if this is the right approach? I originally tried renaming addon/instance-initializers/initialize-store-service.js to addon/instance-initializers/ember-data.js export a full object and had app/instance-initializers/ember-data.js report that object (following the pattern used in the instance-initializers generated from the blueprints). However I ran into a BroccoliMergeTrees error and I didn't feel confident in my broccoli skills to debug the Ember Data's build atm.

…ectory.

That directory seems to be suggesting to ember-load-initializers that
it is a full initializer object and causing an exception to be thrown
in the globals build.

Fixes emberjs#5118
@pangratz pangratz requested a review from rwjblue October 25, 2017 17:27
@rwjblue
Copy link
Member

rwjblue commented Oct 26, 2017

I originally tried renaming addon/instance-initializers/initialize-store-service.js to addon/instance-initializers/ember-data.js export a full object and had app/instance-initializers/ember-data.js report that object (following the pattern used in the instance-initializers generated from the blueprints)

I vaguely think that this is the approach I would take, but either is fine IMHO...

@pangratz pangratz merged commit edd75a9 into emberjs:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants