-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVELTE] Transforms & remove Date.parse polyfill #4936
Merged
stefanpenner
merged 5 commits into
emberjs:master
from
runspired:svelte/cleanup-transforms
Apr 26, 2017
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
import Transform from './transform'; | ||
import Ember from 'ember'; | ||
import { deprecate } from 'ember-data/-debug'; | ||
|
||
Ember.Date = Ember.Date || {}; | ||
|
||
/** | ||
Date.parse with progressive enhancement for ISO 8601 <https://github.com/csnover/js-iso8601> | ||
|
||
© 2011 Colin Snover <http://zetafleet.com> | ||
|
||
Released under MIT license. | ||
|
||
@class Date | ||
@namespace Ember | ||
@static | ||
@deprecated | ||
*/ | ||
Ember.Date.parse = function(date) { | ||
// throw deprecation | ||
deprecate(`Ember.Date.parse is deprecated because Safari 5-, IE8-, and | ||
Firefox 3.6- are no longer supported (see | ||
https://github.com/csnover/js-iso8601 for the history of this issue). | ||
Please use Date.parse instead`, | ||
false, | ||
{ | ||
id: 'ds.ember.date.parse-deprecate', | ||
until: '3.0.0' | ||
}); | ||
|
||
return Date.parse(date); | ||
}; | ||
|
||
|
||
/** | ||
The `DS.DateTransform` class is used to serialize and deserialize | ||
date attributes on Ember Data record objects. This transform is used | ||
when `date` is passed as the type parameter to the | ||
[DS.attr](../../data#method_attr) function. It uses the [`ISO 8601`](https://en.wikipedia.org/wiki/ISO_8601) | ||
standard. | ||
|
||
```app/models/score.js | ||
import DS from 'ember-data'; | ||
|
||
export default DS.Model.extend({ | ||
value: DS.attr('number'), | ||
player: DS.belongsTo('player'), | ||
date: DS.attr('date') | ||
}); | ||
``` | ||
|
||
@class DateTransform | ||
@extends DS.Transform | ||
@namespace DS | ||
*/ | ||
|
||
export default Transform.extend({ | ||
deserialize(serialized) { | ||
let type = typeof serialized; | ||
|
||
if (type === "string") { | ||
let offset = serialized.indexOf('+'); | ||
|
||
if (offset !== -1 && serialized.length - 3 === offset) { | ||
deprecate(`The ECMA2015 Spec for ISO 8601 dates does not allow for shorthand timezone offsets such as +00. | ||
Ember Data's normalization of date's allowing for this shorthand has been deprecated, please update your API to return | ||
UTC dates formatted with ±hh:mm timezone offsets or implement a custom UTC transform.`, | ||
false, | ||
{ | ||
id: 'ds.attr.date.normalize-utc', | ||
until: '3.0.0' | ||
}); | ||
return new Date(`${serialized}:00`); | ||
|
||
// this is a phantom specific bug fix in which +0000 is not supported | ||
} else if (offset !== -1 && serialized.length - 5 === offset) { | ||
offset += 3; | ||
return new Date(serialized.slice(0, offset) + ':' + serialized.slice(offset)); | ||
} | ||
return new Date(serialized); | ||
} else if (type === "number") { | ||
return new Date(serialized) | ||
} else if (serialized === null || serialized === undefined) { | ||
// if the value is null return null | ||
// if the value is not present in the data return undefined | ||
return serialized; | ||
} else { | ||
return null; | ||
} | ||
}, | ||
|
||
serialize(date) { | ||
if (date instanceof Date && !isNaN(date)) { | ||
return date.toISOString(); | ||
} else { | ||
return null; | ||
} | ||
} | ||
}); |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should likely always test this, but only test the expect deprecation in debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@runspired thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I'm not sure (based on how that stripping happens) how to set this up at a glance. I will think.