[BUGFIX] initial-relationship-setup must handle null #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorT
reviewed
Mar 30, 2017
| this.members.add(internalModel); | ||
| this.setupInverseRelationship(internalModel); | ||
| }); | ||
| if (internalModels && internalModels.length) { |
There was a problem hiding this comment.
Why would it be true but not have a length?
There was a problem hiding this comment.
I was just being overly cautious
There was a problem hiding this comment.
I have only ever hit undefined or an array with items in practice
There was a problem hiding this comment.
If it's not undefined but has no length, l think we are in a bad state. We should assert against that in debug maybe, but we shouldn't guard, that would just hide a bug
There was a problem hiding this comment.
Dropped the length check, I suspect asserting length here would be asserting at the wrong layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.