Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Cleanups #4815

Merged
merged 6 commits into from
Feb 23, 2017
Merged

More Cleanups #4815

merged 6 commits into from
Feb 23, 2017

Commits on Feb 22, 2017

  1. remove store._classKeyFor, invoke imported normalizeModelName directly

    @stefanpenner
    stefanpenner committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    575e608 View commit details
    Browse the repository at this point in the history

  2. improve name of cache of modelFactories

    @stefanpenner
    stefanpenner committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    cdb4005 View commit details
    Browse the repository at this point in the history

  3. use default arg

    @stefanpenner
    stefanpenner committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    86c5396 View commit details
    Browse the repository at this point in the history

  4. don’t unnecessarily reify the modelClass

    @stefanpenner
    stefanpenner committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    9b8a752 View commit details
    Browse the repository at this point in the history

  5. make _scheduleFetch no longer depend on a reified modelClass 

    * push modelClass lookups to places where for compat they are still needed (finders invoking adapters)
    @stefanpenner
    stefanpenner committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    be959c9 View commit details
    Browse the repository at this point in the history

  6. Remove store’s dependence on reified modelClass’s 

    push modelClass lookups to places where for compat they are needed:

* finders
* adapters
* store’s internal _commit method
* some debug mode only code
    @stefanpenner
    stefanpenner committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    2bdd30a View commit details
    Browse the repository at this point in the history