More Cleanups #4815
Merged
More Cleanups #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* push modelClass lookups to places where for compat they are still needed (finders invoking adapters)
push modelClass lookups to places where for compat they are needed: * finders * adapters * store’s internal _commit method * some debug mode only code
bmac
reviewed
Feb 23, 2017
| @@ -342,7 +342,7 @@ Store = Service.extend({ | |||
| createRecord(modelName, inputProperties) { | |||
| assert(`You need to pass a model name to the store's createRecord method`, isPresent(modelName)); | |||
| assert(`Passing classes to store methods has been removed. Please pass a dasherized string instead of ${modelName}`, typeof modelName === 'string'); | |||
| let normalizedModelName = this._classKeyFor(modelName); | |||
| let normalizedModelName = normalizeModelName(modelName); | |||
There was a problem hiding this comment.
@runspired I believe you recently introduced _classKeyFor as a wrapper for normalizeModelName. Are you ok with changing this back to just normalizeModelName?
|
lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup
store._classKeyFor