[CLEANUP beta] Linter changes for addon, addon/adapters and addon/serializers #4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pete-the-pete. Thanks for this pr. Would you be opposed to making some changes so I believe Ember follows a convention of "liberally-let" per madhatted.com/2016/1/25/let-it-be and only allows |
|
Sure, i'll update soon. Is it worth it to make the actual eslintrc more similar? https://github.com/emberjs/data/blob/master/.eslintrc.js vs https://github.com/emberjs/ember.js/blob/master/.eslintrc.js |
pete-the-pete
force-pushed
the
linting
branch
from
d40afd7
to
5a742f0
Compare
|
making the .eslintrc.js more similar sounds like a good idea. 👍 |
pete-the-pete
force-pushed
the
linting
branch
from
5a742f0
to
90d5293
Compare
|
Thanks @pete-the-pete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor clean up for linter issues.