Test assertions when updateRecord & deleteRecord don't exist on adapter #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
reviewed
Oct 24, 2016
| function moveRecordOutOfInFlight(record) { | ||
| run(function() { | ||
| // move record out of the inflight state so the tests can clean up | ||
| // correctly |
There was a problem hiding this comment.
@pangratz Do you know why we need to move records out of inflight to make the tests happy?
There was a problem hiding this comment.
It's because of this assertion in the state machine.
|
👍 |
|
Thanks @pangratz. |
pangratz
deleted the
add-more-tests-around-asserting-adapter-methods-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #4283 to add tests for asserting that
updateRecordanddeleteRecordexist.cc @bmac