Revert "unloadRecord does not remove observers" #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pangratz
deleted the
revert-4277-Unload-Record-Does-Not-Remove-Observers
branch
| @@ -122,8 +122,8 @@ var Model = Ember.Object.extend(Ember.Evented, { | |||
| @type {Boolean} | |||
| @readOnly | |||
| */ | |||
| hasDirtyAttributes: Ember.computed('currentState', function() { | |||
| return this.get('_internalModel.currentState.isDirty'); | |||
| hasDirtyAttributes: Ember.computed('currentState.isDirty', function() { | |||
There was a problem hiding this comment.
this seems like it could be a Ember.computed.readOnly('currentState.isDirty')
|
@pangratz bummer. Looks like it was failing on the alpha, beta, and canary builds. Seems like there was a change here that may have caused my issue. After the destroy in unloadRecord, it seems to fail on initial access to
Will look into. Any help would be appreciated. |
|
@ryanpatrickcook looks like there is similar work going on in #4593, which should address the whole unload situation at a broader level. So I am not sure if it's worth pursuing this further for now... Maybe we should wait until that PR is finished and re-check if the test in your PR is still failing or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4277
@ryanpatrickcook Looks like #4277 is not green on current master. Can you reopen a PR based on the latest
master?