Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on running tests in browser #4177

Merged
merged 2 commits into from
Feb 26, 2016
Merged

Elaborate on running tests in browser #4177

merged 2 commits into from
Feb 26, 2016

Conversation

courajs
Copy link
Contributor

@courajs courajs commented Feb 22, 2016

Visting http://localhost:4200 displays the dummy app's "Welcome to Ember" screen. The tests reside at /tests

courajs and others added 2 commits February 21, 2016 20:54
Visting `http://localhost:4200` displays the dummy app's "Welcome to Ember" screen. The tests reside at `/tests`
@sly7-7
Copy link
Contributor

sly7-7 commented Feb 22, 2016

Thank you for the contribution. Thinking a bit more about that, since ember-data is a true ember-cli addon, I wonder if we could just use the basic blueprint generated by ember addon command.

## Installation

* `git clone` this repository
* `npm install`
* `bower install`

## Running Tests

* `npm test` (Runs `ember try:testall` to test your addon against multiple Ember versions)
* `ember test`
* `ember test --server`

## Building

* `ember build`

@bmac @fivetanley Any thoughts ?

@courajs
Copy link
Contributor Author

courajs commented Feb 22, 2016

That's a good point. There are some advantages to the npm start + /tests method though.
ember test --server does pop up a new chrome instance, which I find a little annoying - it's difficult to cmd+tab to the correct one first try.
Since the filtering/single test rerun support isn't there for the phantom runner, I usually stick to the browser anyway.
Not really sure we want to mention both, since that will be confusing to new contributors. "Why are there two options? Which is better?"

@bmac
Copy link
Member

bmac commented Feb 26, 2016

@sly7-7 I'm going to merge this pr as is because it is consistent with how things worked pre ember addon. I'm not opposed to change it to say ember test --server if you or someone else would like to open another pr.

bmac added a commit that referenced this pull request Feb 26, 2016
Elaborate on running tests in browser
@bmac bmac merged commit a77a406 into emberjs:master Feb 26, 2016
@courajs courajs deleted the patch-1 branch January 15, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants