Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] remove toString definitions for models in tests #4164

Merged
merged 1 commit into from
Feb 16, 2016
Merged

[CLEANUP] remove toString definitions for models in tests #4164

merged 1 commit into from
Feb 16, 2016

Conversation

pangratz
Copy link
Member

My string theory: the definitions for toString are a relict from the
pre-container era where this might have been needed. 💈

This makes the recently failing builds for master green again. 🍏


Note: the tests were failing since 2.3.1 ember seals Mixin so adding stuff
after create will error out: emberjs/ember.js#12612.

My string theory: the definitions for `toString` are a relict from the
pre-container era where this might have been needed. 💈

This makes the recently failing builds for `master` green again. 🍏

---

Note: the tests were failing since `2.3.1` ember seals `Mixin` so adding stuff
after `create` will error out.
bmac added a commit that referenced this pull request Feb 16, 2016
[CLEANUP] remove `toString` definitions for models in tests
@bmac bmac merged commit f4d3b9e into emberjs:master Feb 16, 2016
@bmac
Copy link
Member

bmac commented Feb 16, 2016

Thanks @pangratz 🚥

@pangratz pangratz deleted the string-theory branch February 17, 2016 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants