Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run the Ember.onload initializers in globals mode #4003

Merged
merged 1 commit into from
Dec 18, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 0 additions & 80 deletions addon/-private/ember-initializer.js

This file was deleted.

3 changes: 2 additions & 1 deletion addon/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ import {
} from "ember-data/-private/transforms";

import {hasMany, belongsTo} from "ember-data/-private/system/relationships";
import "ember-data/-private/ember-initializer";
import setupContainer from "ember-data/-private/setup-container";
import initializeStoreService from 'ember-data/-private/instance-initializers/initialize-store-service';

import ContainerProxy from "ember-data/-private/system/container-proxy";
import Relationship from "ember-data/-private/system/relationships/state/relationship";
Expand Down Expand Up @@ -148,6 +148,7 @@ DS.Relationship = Relationship;
DS.ContainerProxy = ContainerProxy;

DS._setupContainer = setupContainer;
DS._initializeStoreService = initializeStoreService;

Object.defineProperty(DS, 'normalizeModelName', {
enumerable: true,
Expand Down
32 changes: 32 additions & 0 deletions app/initializers/ember-data.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
import setupContainer from 'ember-data/-private/setup-container';

/*

This code initializes Ember-Data onto an Ember application.

If an Ember.js developer defines a subclass of DS.Store on their application,
as `App.StoreService` (or via a module system that resolves to `service:store`)
this code will automatically instantiate it and make it available on the
router.

Additionally, after an application's controllers have been injected, they will
each have the store made available to them.

For example, imagine an Ember.js application with the following classes:

App.StoreService = DS.Store.extend({
adapter: 'custom'
});

App.PostsController = Ember.ArrayController.extend({
// ...
});

When the application is initialized, `App.ApplicationStore` will automatically be
instantiated, and the instance of `App.PostsController` will have its `store`
property set to that instance.

Note that this code will only be run if the `ember-application` package is
loaded. If Ember Data is being used in an environment other than a
typical application (e.g., node.js where only `ember-runtime` is available),
this code will be ignored.
*/

export default {
name: 'ember-data',
initialize: setupContainer
Expand Down
4 changes: 3 additions & 1 deletion lib/javascripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,15 @@ function collapse(tree, outputFileName) {

var emberDataShimsPath = path.join(__dirname, 'ember-data-shims.js');
var emberDataShims = fs.readFileSync(emberDataShimsPath, { encoding: 'utf8' });
var emberDataInitialierPath = path.join(__dirname, '../tests/ember-data-initializers.js');
var emberDataInitialier = fs.readFileSync(emberDataInitialierPath, { encoding: 'utf8' });

var withLoader = merge([tree, loader, license, emberShim]);
return concat(withLoader, {
inputFiles: ['license.js', 'loader.js', '**/*.js'],
outputFile: '/' + outputFileName,
header: '(function(){ \n"use strict";\n',
footer: '\nrequire("ember-data");\n})();\n' + emberDataShims
footer: '\nrequire("ember-data");\n})();\n' + emberDataShims + emberDataInitialier
});
}

Expand Down
42 changes: 42 additions & 0 deletions tests/ember-data-initializers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
;(function() {
/* globals Ember */
/* globals DS */
var K = Ember.K;
Ember.onLoad('Ember.Application', function(Application) {

Application.initializer({
name: "ember-data",
initialize: DS._setupContainer
});

Application.instanceInitializer({
name: "ember-data",
initialize: DS._initializeStoreService
});

// Deprecated initializers to satisfy old code that depended on them
Application.initializer({
name: "store",
after: "ember-data",
initialize: K
});

Application.initializer({
name: "transforms",
before: "store",
initialize: K
});

Application.initializer({
name: "data-adapter",
before: "store",
initialize: K
});

Application.initializer({
name: "injectStore",
before: "store",
initialize: K
});
});
})();
1 change: 1 addition & 0 deletions tests/test-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
} from 'dummy/tests/helpers/warns';
import addEmberAssertions from 'dummy/tests/helpers/ember-assertions';
import Ember from 'ember';
import './ember-data-initializers';


setResolver(resolver);
Expand Down