Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test on PromiseArray.createRecord when called before hasM… #3968

Merged
merged 1 commit into from
Dec 7, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions tests/integration/relationships/has-many-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2475,3 +2475,40 @@ test("Updated related link should take precedence over local data", function(ass
});
});
});

test("PromiseArray proxies createRecord to its ManyArray before the hasMany is loaded", function(assert) {
assert.expect(1);

Post.reopen({
comments: DS.hasMany('comment', { async: true })
});

env.adapter.findHasMany = function(store, record, link, relationship) {
return Ember.RSVP.resolve([
{ id: 1, body: "First" },
{ id: 2, body: "Second" }
]);
};

run(function() {
var post = env.store.push({
data: {
type: 'post',
id: 1,
relationships: {
comments: {
links: {
related: 'someLink'
}
}
}
}
});

var comments = post.get('comments');
comments.createRecord();
comments.then(function(comments) {
assert.equal(comments.get('length'), 3, "comments have 3 length, including new record");
});
});
});