Throw a more helpful error message if the response from queryRecord i… #3864

bmac · 2015-10-16T14:29:28Z

…s empty

wecc · 2015-10-16T18:44:04Z

packages/ember-data/lib/system/store/finders.js

@@ -175,6 +175,7 @@ export function _queryRecord(adapter, store, typeClass, query) {
    var record;
    store._adapterRun(function() {
      var payload = normalizeResponseHelper(serializer, store, typeClass, adapterPayload, null, 'queryRecord');
+      Ember.assert('`store.queryRecord` expected the adapter to return one record but the response from the adapter was empty.', payload.data);


Shouldn't this assert that payload.data is an object, not just truthy?

bmac · 2015-12-03T16:34:07Z

Igor and I looked at this again and we released its not clear where in the stack to reject a missing findQuery response when there is no information form the protocol (like a 404) thus requiring you to inspect the payload to determine if there response is empty.

…s empty

Throw a more helpful error message if the response from queryRecord i…

The origial intent was for a queryRecord with no response to reject the promise so it would act like a `findRecord` with a 404. This change introduced a regression that broke existing apps so it is going to be reverted. Closes emberjs#4219

[BUGFIX release] Revert pr #3864

The origial intent was for a queryRecord with no response to reject the promise so it would act like a `findRecord` with a 404. This change introduced a regression that broke existing apps so it is going to be reverted. Closes #4219 (cherry picked from commit 274d7b1)

wecc reviewed Oct 16, 2015
View reviewed changes

bmac added the team-review label Dec 3, 2015

Throw a more helpful error message if the response from queryRecord i…

efd0e5d

…s empty

bmac force-pushed the better-error branch from 9b247d2 to efd0e5d Compare December 11, 2015 17:01

bmac removed the team-review label Dec 11, 2015

bmac added a commit that referenced this pull request Dec 11, 2015

Merge pull request #3864 from bmac/better-error

2740417

Throw a more helpful error message if the response from queryRecord i…

bmac merged commit 2740417 into emberjs:master Dec 11, 2015

bmac deleted the better-error branch December 11, 2015 17:54

pangratz mentioned this pull request Mar 8, 2016

queryRecord Regression in Ember Data 2.4 #4219

Closed

bmac added a commit that referenced this pull request Mar 21, 2016

Merge pull request #4256 from bmac/revert-3864

c230d28

[BUGFIX release] Revert pr #3864

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw a more helpful error message if the response from queryRecord i… #3864

Throw a more helpful error message if the response from queryRecord i… #3864

bmac commented Oct 16, 2015

wecc Oct 16, 2015

fivetanley Nov 3, 2015

bmac commented Dec 3, 2015

Throw a more helpful error message if the response from queryRecord i… #3864

Throw a more helpful error message if the response from queryRecord i… #3864

Conversation

bmac commented Oct 16, 2015

wecc Oct 16, 2015

Choose a reason for hiding this comment

fivetanley Nov 3, 2015

Choose a reason for hiding this comment

bmac commented Dec 3, 2015