Deprecate complex objects as an attributes defaultValue.
#3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 |
| @@ -226,7 +226,13 @@ function getDefaultValue(record, options, key) { | |||
| if (typeof options.defaultValue === "function") { | |||
| return options.defaultValue.apply(null, arguments); | |||
| } else { | |||
| return options.defaultValue; | |||
| let defaultValue = options.defaultValue; | |||
| Ember.deprecate(`Non primative defaultValues are deprecated because they are shared between all instances. If you would like to use a complex object as a default value please provide a function that returns the complex object.`, | |||
They often do not work how a user expects. Closes emberjs#3766
bmac
force-pushed
the
deprecate-complex-default-values
branch
from
eabaa57
to
44044fd
Compare
|
❤️ |
igorT
added a commit
that referenced
this pull request
Oct 14, 2015
Deprecate complex objects as an attributes `defaultValue`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They often do not work how a user expects.
Closes #3766