Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo that causes Ember-Data v1.13.10 to crash with Ember v2.0. #3685

Merged
merged 1 commit into from
Aug 21, 2015
Merged

Fixing typo that causes Ember-Data v1.13.10 to crash with Ember v2.0. #3685

merged 1 commit into from
Aug 21, 2015

Conversation

workmanw
Copy link

No description provided.

@bmac
Copy link
Member

bmac commented Aug 21, 2015

Thanks for catching this @workmanw. Looking into the build failure now.

@workmanw
Copy link
Author

Happy to help :)

Let me know if there is anything else I can do to kick it along.

@stefanpenner
Copy link
Member

ROFL, prororororortype (i can laugh because Its my mistake)

@workmanw
Copy link
Author

@stefanpenner @bmac At first I was scratching my head at how that even passed the tests, but because they're run against Ember 1.13, it was just falling back to the Ember.ArrayPolyfills.

@bmac
Copy link
Member

bmac commented Aug 21, 2015

Build should be fixed. @workmanw do you mind rebasing your pr now?

@workmanw
Copy link
Author

Done 🍻

bmac added a commit that referenced this pull request Aug 21, 2015
Fixing typo that causes Ember-Data v1.13.10 to crash with Ember v2.0.
@bmac bmac merged commit b921f6d into emberjs:v1.13 Aug 21, 2015
@bmac
Copy link
Member

bmac commented Aug 21, 2015

Thanks @workmanw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants