Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t crash \w Ember 2.0 #3652

Closed
wants to merge 1 commit into from
Closed

Don’t crash \w Ember 2.0 #3652

wants to merge 1 commit into from

Conversation

stefanpenner
Copy link
Member

There may be more, but this at-least makes my one app work correctly.

  • try getting tests working to get actual confidence.
  • fix other things
  • instead of poluting the Ember object, we should instead add a level of indirection by moving the polifills to a local module, and doing the funky work there.

Goal:

to ease upgrade pain for people

@stefanpenner stefanpenner mentioned this pull request Aug 15, 2015
Closed
@stefanpenner stefanpenner deleted the ember-2-and-1-13 branch August 17, 2015 17:08
@stefanpenner stefanpenner restored the ember-2-and-1-13 branch August 17, 2015 17:08
@stefanpenner
Copy link
Member Author

the GH ui decided after a force push that this was to go to master, unsure why...

new PR is correct again #3667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefanpenner