DS.Store#findQuery overrides DS.Store#query docs
#3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting this @jclem. Would you like to open a pr to fix this issue? |
|
Yes! I will shortly. Didn't before only because I was on the move. |
|
@bmac Actually looks like |
|
If you can open a pr against the release branch we can get that doc fix into the next 1.13 patch release. https://github.com/emberjs/data/tree/release |
|
@jclem would you mind prefixing the commit with |
It was calling `@method query` instead of `@method findQuery`, leading to wrong docs for `DS.Store#query`.
jclem
force-pushed
the
fix-store-find-query-docs
branch
from
2225746
to
1a93098
Compare
|
@wecc all set |
wecc
added a commit
that referenced
this pull request
Jul 28, 2015
`DS.Store#findQuery` overrides `DS.Store#query` docs
|
Thanks! ping @bmac release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS.Store#findQueryis mistakenly marked@method query, soDS.Store#queryis improperly documented and marked as deprecated in the API documentation.