Deprecate normalizePayload and normalizeHash #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1459,6 +1460,7 @@ var JSONSerializer = Serializer.extend({ | |||
| @return {Object} json The deserialized payload | |||
| */ | |||
| extractSingle: function(store, typeClass, payload, id, requestType) { | |||
| Ember.deprecate('`serializer.normalizePayload` has been deprecated. Please use `serializer.normalizeResponse` with the new Serializer API to modify the payload.', this.normalizePayload === JSONSerializer.prototype.normalizePayload); | |||
There was a problem hiding this comment.
This is a bit confusing, should we say extractSingle has been deprecated?
There was a problem hiding this comment.
I put the deprecation of normalizePayload here instead of inside the method since overriding would lose the deprecation. We're only displaying it if the user has overridden normalizePayload:
'...modify the payload.', this.normalizePayload === JSONSerializer.prototype.normalizePayload);
There was a problem hiding this comment.
This is causing thousands of deprecations to be thrown for my application that has a large payload. The logging of all the deprecations is slow and the application load time is impacted. Before this change application load time was nearly instant. Now it is almost 10 seconds.
bmac
added a commit
that referenced
this pull request
Jun 30, 2015
…zeHash Deprecate normalizePayload and normalizeHash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've duplicated the
Ember.deprecatecalls fornormalizePayloadto prevent the deprecation from being silent when users overridenormalizePayloadand don't call super. The example in the docs doesn't even call super.RESTSerializerdoes not overridenormalizePayload, that's why it's comparing withJSONSerializer.prototype.normalizePayload.Closes #3428