Fix deprecation warnings #3433
Merged
Fix deprecation warnings #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
- register store as Ember.Service in the tests - remove deprecated Ember.View from tests - use store.query instead of deprecated store.findQuery - use store.findAll(type) instead of deprecated store.find(type) - use Object.keys instead of deprecated Ember.keys in tests/index.html
| @@ -62,7 +62,7 @@ | |||
|
|
|||
| var skipPackageRegexp = new RegExp('^('+skipPackages.join('|')+')/'); | |||
|
|
|||
| var keys = Ember.keys(requirejs.entries); | |||
| var keys = Object.keys(requirejs.entries); | |||
There was a problem hiding this comment.
This one has been missed in #3432
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept each commit separately to see which deprecations are fixed how. If this is 👍, I will squash them and prefix with
[CLEANUP beta].