make sure deprecate error doesnt get swallowed when using store.push(type, data) #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wecc
added a commit
that referenced
this pull request
Jun 19, 2015
make sure deprecate error doesnt get swallowed when using store.push(type, data)
|
Thanks! |
|
ping @bmac, release |
|
I have cherry-picked this pr into the release branch for the future 1.13.4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now it will get swallowed as it will error out before it gets to the deprecation message which is confusing to users trying to consume the api
http://emberjs.jsbin.com/hiludosuza/1/edit?html,js,console,output