Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter.serialize receives a snapshot #2958

Merged
merged 1 commit into from
Mar 31, 2015
Merged

adapter.serialize receives a snapshot #2958

merged 1 commit into from
Mar 31, 2015

Conversation

rague
Copy link
Contributor

@rague rague commented Mar 30, 2015

Since the beta 16, the serialize method of adapter base class receives a snapshot, not a record. It should not use record._createSnapshot anymore.

@wecc
Copy link
Contributor

wecc commented Mar 30, 2015

Nice catch @rague! Could you update the docs for the method too? (@param {DS.Model} record)

@rague
Copy link
Contributor Author

rague commented Mar 31, 2015

Done !

@wecc
Copy link
Contributor

wecc commented Mar 31, 2015

Do you mind squashing the commits?

@rague
Copy link
Contributor Author

rague commented Mar 31, 2015

I have squashed the commits. It should be ready to merge now, isn't it ?

wecc added a commit that referenced this pull request Mar 31, 2015
adapter.serialize receives a snapshot
@wecc wecc merged commit d85526c into emberjs:master Mar 31, 2015
@wecc
Copy link
Contributor

wecc commented Mar 31, 2015

Thank you!

@rague rague deleted the patch-1 branch April 18, 2015 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants