Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPRECATION] Deprecate setting relationships via PromiseProxies #8817

Closed
runspired opened this issue Nov 2, 2018 · 3 comments
Closed

[DEPRECATION] Deprecate setting relationships via PromiseProxies #8817

runspired opened this issue Nov 2, 2018 · 3 comments

Comments

@runspired
Copy link
Contributor

Users would instead resolve the promise and set value as the actual instance of a record.

A lesser deprecation would only deprecate setting relationships via unresolved promise proxies.
@wagenet wagenet closed this as completed Jul 22, 2022
@wagenet wagenet reopened this Jul 22, 2022
@runspired
Copy link
Contributor Author

I think we may have already completed a deprecation cycle here, I'll have to review and get back.

Because typescript makes it impossible to have an async getter with a sync setter cleaning up the relationship story is high priority. Likely this issue should be replaced with one proposing a new story for relationships.

@runspired runspired mentioned this issue Jul 28, 2022
Closed
@runspired
Copy link
Contributor Author

Still need to handle this for belongsTo, though iirc it won't resolve promises anymore in 5.x

@runspired runspired transferred this issue from emberjs/rfcs Sep 1, 2023
@runspired
Copy link
Contributor Author

confirmed this is handled even for belongsTos now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
EmberData
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagenet @runspired