Redefining DS.Model attributes

[courajs]

In #3893 we found someone was accidentally overwriting DS.Model.errors in an extend block. It's also possible to overwrite other attributes (e.g. isLoading, hasDirtyAttributes) which can cause problem.
Is there a way for us to guard against these redefinitions, or display a warning in the console?

[wecc]

I think these are the only reserved properties at the moment:

data/packages/ember-data/lib/system/model/model.js

Line 25 in fcf5452

'currentState', 'data', 'store'

[courajs]

I think a warning would be good. I could see isLoading being a useful model attribute in some domain, and also something addons might depend on.
Based on the history around that line, we have to be careful about distinctions between instance & class attributes.

[bmac]

Ember Data tried to add a warning around the state properties like (isLoading or hasDirtyAttributes) unfortunately it broke some apps that overrode these properties to provide additional behavior and the change was eventually reverted.

[courajs]

I was suggesting just a console warning rather than an assert. After all, some properties can be safely or usefully overridden (errors by a validation library, for example). Maybe with some mechanism for silencing the warning? An "I know what I'm doing" kind of option.

[wecc]

There are currently no plans on separating user properties from reserved/ED properties. An RFC proposing a solution would be welcomed!

[runspired]

RecordData RFC will move us to a "pluggable" Model setup at which point users may experiment with stricter classes as desired. Closing in favor of that RFC.