-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP based on model.hasDirtyAttributes not firing in ED 1.13.11 / E 1.13.10 #3737
Comments
Does this mean it worked on Ember 1.11 but not 1.12? |
All but the [] example worked on 1.9 thru 1.12, the addition of a [] watcher broke the whole CP, I can't test if adding [] to Ember 1.12 breaks it as project is now migrated |
Same problem with Ember 2.0.2. I cant bind:
We need the |
I found with Ember and EmberData 2.1.0 we cannot bind to ANY property with @each for hasMany relationships (in addition to the report from @svox1.). Won't work:
I believe that this worked once and I think this is a major bug. Happy to help if I can support. Any workaround appreciated. Update: I'm now sure this once worked. We are currently upgrading from Ember 1.11.0 and EmberData 1.0.0-beta.15. In the old version the computed property subscribed to model.pages.@each.isDirty. A change of any attribute of the page affected the computed property. Now with model.pages.@each.hasDirtyAttributes this computed property never gets updated if any of the pages properties changes. This is also an issue for observers, not only for computed properties. |
Related to emberjs/ember.js#12475 |
I believe this has been fixed in Ember by emberjs/ember.js#12908 |
Currently have a model with numerous hasMany's, e.g.
It is initialised in the pod route, and
controller.set('model', model);
so it is visible in the controller and template, which it is through the usual model.myModel.When I create a CP with the structure;
or
where conditions are all combinations of;
the CP does not fire when there is a change to the model or nested models. The change is visible in Ember Inspector.
This worked with the same ED 1.13 but Ember v1.12, and for the upgrade of this CP initially I added [] references which caused things to break, then on reverting to just the @each (first and last lines in list above) it worked again.
There doesnt seem to be an explanation of [] on http://guides.emberjs.com/v1.13.0/object-model/computed-properties-and-aggregate-data/
Any ideas? Thanks
The text was updated successfully, but these errors were encountered: