ignores keys that are not found in the map

emberjs · Dec 14, 2015 · 269d888 · 269d888
1 parent 845d969
commit 269d888
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/addon/serializers/json-serializer.js b/addon/serializers/json-serializer.js
@@ -716,11 +716,11 @@ export default Serializer.extend({
   */
   normalizeUsingDeclaredMapping: function(modelClass, hash) {
     var attrs = get(this, 'attrs');
-    var payloadKey, normalizedKey, key;
+    var normalizedKey, payloadKey, key;
 
     if (attrs) {
       for (key in attrs) {
-        payloadKey = this._getMappedKey(key, modelClass);
+        normalizedKey = payloadKey = this._getMappedKey(key, modelClass);
 
         if (!hash.hasOwnProperty(payloadKey)) { continue; }
 

diff --git a/tests/integration/serializers/json-serializer-test.js b/tests/integration/serializers/json-serializer-test.js
@@ -885,3 +885,24 @@ test('normalizeResponse respects `included` items (array response)', function(as
     { id: "3", type: "comment", attributes: { body: "comment 3" }, relationships: {} }
   ]);
 });
+
+test('normalizeResponse ignores unmapped attributes', function(assert) {
+  env.registry.register("serializer:post", DS.JSONSerializer.extend({
+    attrs: {
+      title: { serialize: false },
+      notInMapping: { serialize: false }
+    }
+  }));
+
+  var jsonHash = {
+    id: "1",
+    notInMapping: 'I should be ignored',
+    title: "Rails is omakase"
+  };
+
+  var post = env.store.serializerFor("post").normalizeResponse(env.store, Post, jsonHash, '1', 'findRecord');
+
+  assert.equal(post.data.attributes.title, "Rails is omakase");
+});
+
+