From 2ded4211fdb30c4cc85fe0e3ac7da56baa389943 Mon Sep 17 00:00:00 2001 From: Mike Hollis Date: Sat, 13 Jun 2015 14:23:14 -0400 Subject: [PATCH] Deprecate store.pushMany in favor of store.push --- packages/ember-data/lib/system/store.js | 1 + packages/ember-data/tests/unit/store/push-test.js | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/packages/ember-data/lib/system/store.js b/packages/ember-data/lib/system/store.js index 24693bbff89..0cb9fafb315 100644 --- a/packages/ember-data/lib/system/store.js +++ b/packages/ember-data/lib/system/store.js @@ -1901,6 +1901,7 @@ Store = Service.extend({ */ pushMany: function(modelName, datas) { Ember.assert('Passing classes to store methods has been removed. Please pass a dasherized string instead of '+ Ember.inspect(modelName), typeof modelName === 'string'); + Ember.deprecate('Using store.pushMany() has been deprecated since store.push() now handles multiple items. You should use store.push() instead.'); var length = datas.length; var result = new Array(length); diff --git a/packages/ember-data/tests/unit/store/push-test.js b/packages/ember-data/tests/unit/store/push-test.js index e4f9bcf5387..9f107182c43 100644 --- a/packages/ember-data/tests/unit/store/push-test.js +++ b/packages/ember-data/tests/unit/store/push-test.js @@ -584,3 +584,15 @@ test("Calling push with unknown keys should not warn by default", function() { }); }, /The payload for 'person' contains these unknown keys: \[emailAddress,isMascot\]. Make sure they've been defined in your model./); }); + +test("Calling pushMany is deprecated", function() { + var person1, person2; + expectDeprecation(function() { + run(function() { + person1 = { id: 1, firstName: 'John', lastName: 'Smith' }; + person2 = { id: 2, firstName: 'Suzie', lastName: 'Q' }; + + store.pushMany('person', [person1, person2]); + }); + }, 'Using store.pushMany() has been deprecated since store.push() now handles multiple items. You should use store.push() instead.'); +});