Update the Super Rentals Tutorial to use the Request Service #238
Conversation
|
@IgnaceMaes can you please take another look at this one? |
This change is needed to avoid confusion around model names. Previosly JsonApiSerializer was singularizing type of every json-api response object, so convention "model name should be singular always was met. In new world, we don't do automatic conversion of payloads and try to have them as close as possible to network response. So if application developers do not manually add singularization of json-api response objects type - it will never happen. Therefore expected model name would be plural, or in better words match type from payload.
Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com>
Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
|
Looking good! The code style comments are minor details, but I believe it's important to consciously think about how we handle these. Users see the guides as the recommended way of structuring an app and will take over this style. |
|
Looks like the code block languages and filenames are not set. @Baltazore could you look into opening a new PR to add these? |
Sure will do, what are the expectations for filenames to show up? Any ideas why it does not work ? |
Looking at the other examples, it seems like the files need to be added to git. When looking into the source files there are a couple of code blocks that are passed a flag hidden, with git add commands. That would be my guess, but I'm still in the process of figuring out this tutorial builder app too, heh 😄 |
|
Nevermind, that was done I see just now. It looks like the lang attributes were missing. |
Fixes #232
Brings updates to Chapter 11 of tutorial.