Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP proof of concept for separate data guides #1841

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Sep 1, 2022

This PR should not be merged.

If we wanted to pursue this strategy, we would make a new repo or add it to the ember data mono repo.

See the link in CI checks below for a demo URL.

Things that would have to happen for this to ship:

  • Handle older versions
  • Tests
  • subdomain
  • redirects/SEO. How do we handle the big hole this would leave in the ember guides? Maybe all pages point to a page that says "go here for the latest" and we call that good enough?
  • use a production version of ember-styleguide
  • readme, site meta, etc.

challenges

  • If I put this into the data mono repo, I get warnings that dependencies are not installed. What to do?

Blockers

  • the new styling work needs to ship before this

Screen Shot 2022-08-31 at 8 35 08 PM

@jenweber jenweber marked this pull request as draft December 6, 2022 22:40
@jenweber
Copy link
Contributor Author

jenweber commented Dec 6, 2022

Steps to run:

  • check out this branch
  • npm install
  • npm start

Problems? Check your node version

Notes to self about monorepo debugging

@Baltazore
Copy link

hey @jenweber and learning team, is there any new thoughts about this PR? EmberData docs in general? What would be preferred approach for EmberData docs? Separate repo ? Part of general Ember Guides ? Please let me know. I want to start working on updates to latest EmberData APIs.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants