Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Embroider Readers Question #953

Merged
merged 5 commits into from
May 8, 2021
Merged

Add Embroider Readers Question #953

merged 5 commits into from
May 8, 2021

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented May 6, 2021 •
edited
Loading

Note: I'm thinking we should maybe wait until the RFC goes live. Let me know what you think / I xposted in #support-ember-times-staff: https://discord.com/channels/480462759797063690/619289054537711616/839670860020842506

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

What it does

Related Issue(s)

Sources

@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label May 6, 2021
@amyrlam amyrlam requested a review from a team May 6, 2021 01:08
@amyrlam amyrlam changed the title Add Embroider Readers Question [WIP] Add Embroider Readers Question May 6, 2021
amyrlam and others added 2 commits May 7, 2021 21:29
@amyrlam @ijlee2
Update content/the-ember-times-issue-179.md
4e2556b 
Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
@amyrlam
Update writeup with RFC
817d414
@amyrlam amyrlam changed the title [WIP] Add Embroider Readers Question Add Embroider Readers Question May 8, 2021
@amyrlam amyrlam marked this pull request as ready for review May 8, 2021 05:12
@amyrlam amyrlam merged commit 388d294 into blog/embertimes-179 May 8, 2021
@amyrlam amyrlam deleted the amy/embroider branch May 8, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijlee2 ijlee2 ijlee2 left review comments

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyrlam @ijlee2