-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing ember-fetch breaks source maps for prod builds #119
Comments
The problem was introduced with v4.0.0. While warning about deprecations, the source map gets built correctly:
|
Which is weird, because according to |
Oops, it's not |
It's Works:
Breaks:
|
Lines 128 to 130 in d25abf6
This means that later, when One possible fix is passing |
I guess the file ends up here and So I guess passing |
Fixes #119. When the ember-fetch.js file is eventully pulled into vendor.js and minifcation with source map generation is enabled, a rogue sourceMappingURL comment sneaks in and breaks everything. This PR removes that rogue comment.
@stefanpenner @tchak see comment here broccolijs/broccoli-concat#123 (comment) |
Under repo https://github.com/buschtoens/ember-fetch-sourcemap-bug
No more |
So the solution here was to nuke the yarn.lock file? 🤣 |
Demo: https://github.com/buschtoens/ember-fetch-sourcemap-bug
Installing ember-fetch breaks source maps for prod builds (i.e. builds with minification enabled).
During the build, the following warning is emitted:
Source map output without ember-fetch:
Source map output with ember-fetch:
The text was updated successfully, but these errors were encountered: