Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embroider Support #490

Closed
NullVoxPopuli opened this issue Feb 2, 2020 · 1 comment · Fixed by #599
Closed

Embroider Support #490

NullVoxPopuli opened this issue Feb 2, 2020 · 1 comment · Fixed by #599

Comments

@NullVoxPopuli
Copy link
Contributor

When I have:

// tests/test-helper.js
import start from 'ember-exam/test-support/start';
// import { start } from 'ember-qunit';

I get the following error at /tests:

image

I think this may be a similar issue as: mainmatter/qunit-dom#542
cc @ef4

@ef4
Copy link
Contributor

ef4 commented Feb 3, 2020

I actually happened to hit this same issue in an app this week, and it's on my todo list to debug it.

I don't think ember-exam is doing anything wrong here. It's relying on babel-plugin-module-resolver, which comes with ember-cli-htmlbars, which rewrites require with relative paths like that one to full package-absolute paths.

It looks like either embroider is causing that plugin to get dropped, or embroider's own plugin that rewrites require to window.require is running first and interrupting babel-plugin-module-resolver from doing the job.

There is another blocking bug in ember-exam when it comes to working under embroider, see #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants