-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-repo addon dependencies #4164
Comments
If a given dep exists in the project's The idea behind in-repo-addons is that they are relatively lightweight and low ceremony. If you find yourself needing the addon to have nested dependencies that do not belong in the project itself you should likely consider making it a full fledged addon instead... |
Great, thanks for the info, makes sense. The use-case was themes so I needed any preprocessing to run within the addon first, which required the dependency at the addon's level. I have some other ideas. Thanks! |
I've added some dependencies to an in-repo addon's package.json dependencies hash. They only work if you run
npm install
directly in that addon's directory. It is possible for them to install when runningnpm install
from the project root (like standard addons)? Doing it from each directory is a slightly awkward requirement to someone cloning the project.The text was updated successfully, but these errors were encountered: